feat: allow brackets when parsing library names #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
reviewed
Nov 10, 2021
| @@ -43,7 +43,7 @@ echo -e "rules: | |||
| constraint_files = set() | |||
|
|
|||
| # groups \"my-package-name<=x.y.z,...\" into (\"my-package-name\", \"<=x.y.z,...\") | |||
| requirement_line_regex = re.compile(r\"([a-zA-Z0-9-_.]+)([<>=][^#\s]+)?\") | |||
| requirement_line_regex = re.compile(r\"([a-zA-Z0-9-_.\[\]]+)([<>=][^#\s]+)?\") | |||
There was a problem hiding this comment.
Suggested change
| requirement_line_regex = re.compile(r\"([a-zA-Z0-9-_.\[\]]+)([<>=][^#\s]+)?\") | |
| requirement_line_regex = re.compile(r\"([a-zA-Z0-9\-_.\[\],]+)([<>=][^#\s]+)?\") |
There can be more than one extra in the list, so we should have a comma as well. And probably want to escape this hyphen, even though it shouldn't cause trouble at the moment (since there's a range just before it).
There was a problem hiding this comment.
Theoretically, there could also be whitespace around that comma or probably even the brackets. I don't see any instances of that in our code, though. 🤔
|
Looks like this was handled by #377. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the regex used to match library names to allow brackets for things like
pyjwt[crypto]JIRA:
ARCHBOM-1772
Merge checklist: