Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't filter out extras for a pip dependency. #377

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: Don't filter out extras for a pip dependency. #377

merged 1 commit into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. fix: Don't filter out extras for a pip dependency. 

    Before this change, the function was dropping extra dependencies. For
example:

If you had a requirements file like the following:
```
Xblock[django]
```

It will output: `Xblock`

The correct output should be `Xblock[django]`

This drops the extras which may have further constraint requirements or
more packages that are required. In the example, the package would need
Django but that dependency would not be visible upstream correctly.
    @feanil
    feanil committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c340961 View commit details
    Browse the repository at this point in the history