feat: upgrading django-simple-history. #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 158 158
Lines 17429 17429
Branches 1626 1626
=======================================
Hits 16572 16572
Misses 642 642
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awais786
commented
Jul 29, 2023
| django-simple-history==3.3.0 | ||
| # via -r requirements/base.in | ||
| django-waffle==3.0.0 | ||
| django-simple-history==3.1.1 |
There was a problem hiding this comment.
django-simple-history==3.1.1
awais786
force-pushed
the
update-simple-history-package-version
branch
from
1ce8b24
to
e34ac25
Compare
|
We have to add pending migrations in edx-platform coming due to |
|
docs check failure will be fixed in the PR #2017 so merging with failing check to resolve django-simple-history blocker for edx-platform due to this package. |
UsamaSadiq
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the attempt to upgrade
historypackage in theedx-platformrepo, the check-migrations-test encountered a failure with new migrations. The updated package includes some enhancements that introduce new migrations. However, these migrations do not involve any alterations to the existing fields; instead, they are focused on meta changes aimed at improving the ordering functionality e.goptions={'get_latest_by': ('history_date', 'history_id'https://django-simple-history.readthedocs.io/en/latest/#section-1
Upgrading the package to
3.1.1These are due to the package. Related PR jazzband/django-simple-history#862 ( this pr shows the get_latest_by usage )
Similar PR merged in credentials