Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: UI refactor ADR #2049

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs: UI refactor ADR #2049

wants to merge 3 commits into from

Conversation

nsprenkle
Copy link
Contributor

TL;DR - Add ADR for UI mixin refactors.

What changed?

  • Add ADR 003
  • Link repo docs in README.rst

Developer Checklist

Testing Instructions

n/a

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual documentation review

FYI: @openedx/content-aurora

@nsprenkle nsprenkle changed the base branch from master to aurora/bff-datalayer September 12, 2023 19:11
Base automatically changed from aurora/bff-datalayer to master September 13, 2023 16:29
@nsprenkle nsprenkle marked this pull request as ready for review September 14, 2023 14:42
@nsprenkle nsprenkle requested a review from a team as a code owner September 14, 2023 14:42
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2b9694) 95.04% compared to head (add7720) 95.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         178      178           
  Lines       18145    18145           
  Branches     1656     1656           
=======================================
  Hits        17246    17246           
  Misses        677      677           
  Partials      222      222           
Flag Coverage Δ
unittests 95.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants