feat: serial workflow advance fix #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 191 191
Lines 20568 20570 +2
Branches 1864 1864
=======================================
+ Hits 19526 19528 +2
Misses 779 779
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nsprenkle
force-pushed
the
nsprenkle/bff-serial-workflow-advance-fix
branch
from
56b76c3
to
78f3251
Compare
nsprenkle
requested review from
mattcarter,
jansenk,
muselesscreator,
leangseu-edx and
jszewczulak
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* fix: also check "graded" on workflow when advancing * chore: bump ORA to 6.0.21 * style: more consistent styling in workflow API file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - Check both
gradedandcompleteworkflow status indicators to confirm we've completed a workflow step instead of justcomplete.What changed?
In the new ORA UI we serially progress through steps, blocking movement forward to a subsequent step until all requirements are met for the current step. This blocks us from determining workflow status directly (as previously, we would jump forward as far as you are able to view, skipping peer if it was followed by an additional step) and requires us to manually determine how far we have progressed.
Previous checks incorrectly determined this by only checking
complete(whether you have finished your required work on a step) instead of also checkinggraded(whether you have received required external grades e.g. from peers).This adds the additional check that both
completeandgradedmust beTruefor a step to be considered finished.Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora