-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow learner resubmissions in ora assignment #2187
feat: allow learner resubmissions in ora assignment #2187
Conversation
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
8b475c8
to
0e2899a
Compare
openassessment/templates/legacy/edit/oa_edit_basic_settings_list.html
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
==========================================
+ Coverage 95.06% 95.09% +0.02%
==========================================
Files 193 195 +2
Lines 21285 21479 +194
Branches 1918 1931 +13
==========================================
+ Hits 20235 20425 +190
- Misses 785 787 +2
- Partials 265 267 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
722345a
to
12be208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, so my review is incomplete, but I left some comments for you to review. Thank you!
openassessment/templates/legacy/edit/oa_edit_basic_settings_list.html
Outdated
Show resolved
Hide resolved
openassessment/templates/legacy/response/oa_response_submitted.html
Outdated
Show resolved
Hide resolved
0078db8
to
25167c8
Compare
c8c2dd9
to
3ef4d21
Compare
f98e22e
to
72546ec
Compare
6a579e3
to
538ecaa
Compare
Hi @pomegranited, thank you very much for your review!. The tests are passing and I bumped the version. The PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Working perfectly, thank you @BryanttV !
- I tested this on my tutor dev stack.
- ensured option is not shown if peer step in workflow
- as student: submitted and re-submitted works as expected within the grace period
- as staff: started grading response, which disabled student resubmission
- I read through the code
- I checked for accessibility issues by using my keyboard only when navigating.
✖️ Was unable to use my keyboard to re-expand the "Complete" submission tab (unrelated to this change), but once that's visible, can reset the response with the keyboard. - Includes documentation for the new settings
- User-facing strings are extracted for translation
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR allows a learner to reset and make a new submission. Instructors will activate this functionality from the component settings, and can optionally define a grace period.
To allow a learner to reset their submission the following conditions must be met:
Supporting Information
These changes are part of the effort made to implement Resetting ORA submissions
What changed?
Two (2) new fields were included in the ORA settings:
A new button (Reset submission) was included in the Your Response step.
A new module
allow_resubmission
was included to validate if the learner is allowed to make a resubmission.Developer Checklist
Testing Instructions
Using Tutor:
edx-ora2
with the changes in this branch.True
ora-resubmissions-demo-v3.mp4
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora
Deadline
This effort is part of the Spanish consortium project, so it'd be ideal to merge this before the end of the project.