-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Notifications for staff. #2201
Conversation
4c0d83e
to
e1310fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
f143bf1
to
54f08bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 191 193 +2
Lines 21098 21149 +51
Branches 1904 1906 +2
=======================================
+ Hits 20055 20104 +49
- Misses 779 780 +1
- Partials 264 265 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbc8bdd
to
985e336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
there seems to be a conflict, can you please resolve that? Thanks!
s: added notification for staff s: added notification for staff s: updated version s: updated version fix: resolved failing tests fix: resolved failing tests feat: added unit test for notification util feat: added unit test for notification util
985e336
to
c8fc9c2
Compare
Ticket
https://2u-internal.atlassian.net/browse/INF-1304
Description
To implement notiifcation for staff installed openedx-events and created signal for notification when\ever there is new submission , and next step in work flow is staff grading.
todo : update ora version and add tests