Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use get to avoid key error #2213

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: use get to avoid key error #2213

merged 2 commits into from
May 23, 2024

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented May 23, 2024

** If the environment doesn't have ENABLE_ORA_PEER_CONFIGURABLE_GRADING defined this line will throw a keyerror

  • Note: I don't know why it isn't defined? It looks like it should be? Nevertheless the error is thrown. Investigation for another time.

JIRA: CR-6800

FYI: @openedx/content-aurora

@jansenk jansenk requested a review from a team as a code owner May 23, 2024 19:03
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (9359c44) to head (3163fae).
Report is 2 commits behind head on master.

Files Patch % Lines
openassessment/xblock/utils/validation.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2213   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         195      195           
  Lines       21479    21479           
  Branches     1931     1931           
=======================================
  Hits        20425    20425           
  Misses        787      787           
  Partials      267      267           
Flag Coverage Δ
unittests 95.09% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansenk
Copy link
Contributor Author

jansenk commented May 23, 2024

The only failure is codecov. I'm trying to fix an active issue. Not gonna bother with codecov right now

Copy link
Member

@BrandonHBodine BrandonHBodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jansenk jansenk merged commit 8b320d6 into master May 23, 2024
10 of 11 checks passed
@jansenk jansenk deleted the jkantor/keyerror branch May 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants