Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown should be escaped when converting to XML #365

Closed
thinxer opened this issue Jul 10, 2013 · 4 comments
Closed

Markdown should be escaped when converting to XML #365

thinxer opened this issue Jul 10, 2013 · 4 comments

Comments

@thinxer
Copy link

thinxer commented Jul 10, 2013

Here:

https://github.com/edx/edx-platform/blob/master/common/lib/xmodule/xmodule/js/src/problem/edit.coffee#L191

This code (toXML) doesn't escape "&""<"">" to HTML entities, which may cause the resulted XML to be invalid.
@Slater-Victoroff
Copy link
Contributor

@gwprice @mikigoyal Where did we land on escaping issues?

@gwprice
Copy link

gwprice commented Jul 13, 2013

@Slater-Victoroff I'm not sure what you mean. I was looking at escaping in the mako templates. I don't know anything about escaping functionality in coffee.

@IainNZ
Copy link
Contributor

IainNZ commented Oct 4, 2013

Bumping this issue - it really causes issues when giving R code examples in a class we're making.

@singingwolfboy
Copy link
Contributor

Is this still a problem in the latest version of the codebase?

@baby636 baby636 mentioned this issue Nov 5, 2022
Open
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this issue Nov 17, 2022
fix null course goal object bug (openedx#365)
49bfc65
@baby636 baby636 mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thinxer @singingwolfboy @IainNZ @Slater-Victoroff @gwprice