-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just write the loc name as the key in the policy file #1124
Conversation
Is there any way to unit test the scenario of importing into a new course (ie., something that would have caught the bug)? |
I like the idea! My only worry is Christina's - I suspect there might not be anything within export/import tests that test this. |
Are there any unit tests which test importing into a different course than On Wed, Sep 25, 2013 at 11:14 AM, jkarni notifications@github.com wrote:
|
It looks like test_export_course in test_contentstore exports, deletes that course, then imports. I think that would catch the bug (as long as you can use a different course location when you import). |
Looks good to me. After Christina's merge, a rebase, and a Jenkins checkmark, 👍 . |
@cahrens please approve (I removed your commits from this history) |
rewrote test and proved it failed w/o my fix On Wed, Sep 25, 2013 at 1:16 PM, Christina Roberts <notifications@github.com
|
👍 |
Just write the loc name as the key in the policy file
YONK-1023 SAML Vulnerability - updating python-saml version
…el_courses GI-2 Adding carousel_courses to the view context.
Since the only thing that varies per asset location w/in a course is the name, just use that as the key in the policy dict.
@cahrens @jkarni Please review.
Enables export from one course and import into another (also more compatible w/ new Locators)