Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just write the loc name as the key in the policy file #1124

Merged
merged 2 commits into from
Sep 25, 2013

Conversation

dmitchell
Copy link
Contributor

Since the only thing that varies per asset location w/in a course is the name, just use that as the key in the policy dict.

@cahrens @jkarni Please review.

Enables export from one course and import into another (also more compatible w/ new Locators)

@cahrens
Copy link

cahrens commented Sep 25, 2013

Is there any way to unit test the scenario of importing into a new course (ie., something that would have caught the bug)?

@jkarni
Copy link

jkarni commented Sep 25, 2013

I like the idea! My only worry is Christina's - I suspect there might not be anything within export/import tests that test this.

@dmitchell
Copy link
Contributor Author

Are there any unit tests which test importing into a different course than
was exported? Seems like a bigger issue, but I'll look at it tomorrow.

On Wed, Sep 25, 2013 at 11:14 AM, jkarni notifications@github.com wrote:

I like the idea! My only worry is Christina's - I suspect there might not
be anything within export/import tests that test this.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1124#issuecomment-25095120
.

@cahrens
Copy link

cahrens commented Sep 25, 2013

It looks like test_export_course in test_contentstore exports, deletes that course, then imports. I think that would catch the bug (as long as you can use a different course location when you import).

@jkarni
Copy link

jkarni commented Sep 25, 2013

Looks good to me. After Christina's merge, a rebase, and a Jenkins checkmark, 👍 .

@dmitchell
Copy link
Contributor Author

@cahrens please approve (I removed your commits from this history)

@dmitchell
Copy link
Contributor Author

rewrote test and proved it failed w/o my fix

On Wed, Sep 25, 2013 at 1:16 PM, Christina Roberts <notifications@github.com

wrote:

It looks like test_export_course in test_contentstore exports, deletes
that course, then imports. I think that would catch the bug (as long as you
can use a different course location when you import).


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1124#issuecomment-25106566
.

@cahrens
Copy link

cahrens commented Sep 25, 2013

👍

dmitchell added a commit that referenced this pull request Sep 25, 2013
Just write the loc name as the key in the policy file
@dmitchell dmitchell merged commit 82af8d4 into master Sep 25, 2013
@jzoldak jzoldak deleted the dhm/asset_policy branch May 5, 2014 14:54
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Aug 25, 2016
pomegranited pushed a commit to open-craft/edx-platform that referenced this pull request Aug 15, 2018
YONK-1023 SAML Vulnerability - updating python-saml version
cocococosti pushed a commit to Pearson-Advance/edx-platform that referenced this pull request Aug 18, 2020
…el_courses

GI-2 Adding carousel_courses to the view context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants