disable buttons prototype for legacy and beta instr dash #1125
Conversation
| @@ -45,10 +46,21 @@ def instructor_dashboard_2(request, course_id): | |||
| _section_analytics(course_id), | |||
| ] | |||
|
|
|||
| # disable_buttons = True | |||
|
Functionally this works but I don't like most of the added text. Hopefully Marco can add to/augment my comments. Marco, here's a screenshot of what one of these areas looks like (this is a small course): |
|
@flowerhack and @marcotuts , can you take a look? |
|
This looks good to me. |
|
@adampalay can you post some screenshots of what things look like where you've made changes? I think that helps Marco review things faster. |
|
While that is true, I'll review this now :) |
| @@ -150,31 +150,45 @@ <h2 class="navbar">[ <a href="#" onclick="goto('Grades');" class="${modeflag.get | |||
| <input type='checkbox' name='use_offline_grades' value='${_("yes")}'></font> </p> | |||
| %endif | |||
|
|
|||
|
|
|||
| <hr width="40%" style="align:left"> | |||
There was a problem hiding this comment.
I think we'll want to remove all inline styles from this over to the appropriate .scss file, I'll note every instance of that below.
|
some screenshots: |
|
I like it! Maybe add something nice at the end like "Thank you for your patience as we continue working to improve your user experience!" or something. |
|
@talbs , thanks for the new sass rules. For some reason, they're not working on the beta dash: https://github.com/edx/edx-platform/blob/0ccf0cd14c9a61cceda7723baf70bbf2de666b9d/lms/templates/instructor/instructor_dashboard_2/data_download.html#L7-L19 Here's a screenshot: |
|
👍 |
|
Can we make these small copy tweaks please: Note: some of these buttons are known to time out for larger "
|
set max enrollment for downloads to 200
…Dashboard view LMS: adds message styling to the separate instructor_2 Sass file
|
@shnayder , updated the message. |
|
@adampalay Thanks, looks good. |
disable buttons for legacy and beta instr dash
…bump-eoc-xblock Update EOC Journal XBlock
PE-831 Fix accounactivation email body template.
Disables buttons on the instructor dash that don't work for large courses (>500 here).
Adds a note that these buttons are for smaller courses only, and a subheading that they are disabled for larger courses. The subheading turns red for large courses.
@sarina @flowerhack @marcotuts