Hotfix/lms a11y #1131
Merged
Hotfix/lms a11y #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. 👍 |
|
This matches the fixes we've put into place elsewhere for similar modal interactions, correct? It looks to be and seems fine to me. 👍 PS - We should have a longer talk on how to have a definitive and extensible modal UI that can be a little less redundant. I'll put an issue/story in for the LMS. |
Merged
lgp171188
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Aug 16, 2018
…er-api [MCKIN-8112] Integrate the openedx-user-manager-api into Ginkgo
cocococosti
pushed a commit
to Pearson-Advance/edx-platform
that referenced
this pull request
Aug 18, 2020
…provement PE-944-improvement - Checking if the user has a SAML provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a11y hotfixes for:
be able to escape the forgot password modal by pressing "ESC"
https://edx-wiki.atlassian.net/browse/LMS-1166
fix typo at https://github.com/edx/edx-platform/compare/release...hotfix/lms-a11y?expand=1#L1L64
https://edx-wiki.atlassian.net/browse/LMS-583
manage focus within help modal once "submit" has been hit
https://edx-wiki.atlassian.net/browse/LMS-581
@talbs @singingwolfboy
@gwprice , coming your way