Switch to SharedModuleStoreTestCase in the 'contentstore' app where possible. #11552
Conversation
|
/cc @ormsbee |
|
@doctoryes: Do you have a moment to review some test optimizations? @tobz is converting some of our suite from |
| def setUp(self): | ||
| super(TestTaskExecution, self).setUp() | ||
| SignalHandler.course_published.disconnect(listen_for_course_publish) | ||
| SignalHandler.library_updated.disconnect(listen_for_library_update) |
There was a problem hiding this comment.
Do we still need to disconnect signals here, since nothing is happening in the setup?
There was a problem hiding this comment.
Actually, does this setUp() need to exist at all?
There was a problem hiding this comment.
Good question. It seems like they could be in the class setup. I'll try it and see what happens.
|
Minor issue about signal disconnecting and whether that particular |
|
That's how it's done - and all tests still pass, so seems like no test-to-test interference. 👍 |
Switch to SharedModuleStoreTestCase in the 'contentstore' app where possible.
This is switching from ModuleStoreTestCase, to SharedModuleStoreTestCase, where possible. This is only for the 'contentstore' Django application. This helps speed up some tests where there's a lot of write-once-read-many for modulestore-based data.