asadiqbal08-xblock translations initial tests #11628
Conversation
asadiqbal08
force-pushed
the
asadiqbal08/xblock_translations_tests
branch
from
e23aa0f
to
493599b
Compare
|
jenkins run python |
|
@mattdrayer there is a test that is failing locally as well, I will look into that. |
|
hah, I was just going to look into that -- you should be sleeping :) FYI, I am currently rebasing #11575 onto the latest master and squashing some of the older commits. |
mattdrayer
force-pushed
the
mattdrayer/xblock-translations
branch
2 times, most recently
from
fa3ca94
to
8d5f86e
Compare
mattdrayer
force-pushed
the
asadiqbal08/xblock_translations_tests
branch
from
493599b
to
92ae8e9
Compare
asadiqbal08
force-pushed
the
asadiqbal08/xblock_translations_tests
branch
5 times, most recently
from
d75413f
to
d092430
Compare
|
@mattdrayer I updated this PR, Kindly look into that tests and I hope Jenkins will pass all the tests and then we will merge into parent but We got an email from @benpatterson about jenkins failure behavior. Thanks |
| old_lang = translation.get_language() | ||
|
|
||
| # Activate french, so that if the fr files haven't been loaded, they will be loaded now. | ||
| translation.activate("fr") |
There was a problem hiding this comment.
If the test is going to change global state like the current language, then you need an addCleanup in setUp that will restore it. Setting it back inside the test isn't enough because the test won't complete if it fails.
asadiqbal08
force-pushed
the
asadiqbal08/xblock_translations_tests
branch
from
5bb0b25
to
e2543c7
Compare
|
Jenkins is happy -- I'm going to merge this child branch into the main feature branch now. |
asadiqbal08-xblock translations initial tests
@mattdrayer fyi.