feat: AA-1205: Add Learning MFE support for Entrance Exams #30001
Conversation
Dillon-Dumesnil
force-pushed
the
ddumesnil/entrance-exam-support-aa-1205
branch
from
7132011
to
3563a75
Compare
| entrance_exam_score_ratio = 0.0, 0.0 | ||
| entrance_exam_score = 0.0 |
There was a problem hiding this comment.
So this is a bit of a change, but honestly, this default return value is wild. I think it was meant to represent the earned, possible grade, but forgot to do the division. The output of this is never expecting a tuple and this is the only spot that would return it as such. So I updated it and renamed the function since it's just a score.
| version = IntegerField() | ||
| version = models.IntegerField() |
There was a problem hiding this comment.
All of these changes are just to be more inline with the preferred way of defining these fields according to django
Dillon-Dumesnil
force-pushed
the
ddumesnil/entrance-exam-support-aa-1205
branch
2 times, most recently
from
dd793a8
to
e592c19
Compare
| name='entrance_exam_minimum_score_pct', | ||
| field=models.FloatField(default=0.65), | ||
| ), | ||
| migrations.AddField( |
There was a problem hiding this comment.
I'm not sure I understand what historicalcourseoverview is. What do these fields do?
There was a problem hiding this comment.
The historical model keeps a changelog of all updates to the actual model. So say you update the description, the actual model will just update to the new description, but the historical model will have a row containing the old description and a row with the new description. Essentially, the historical model.latest() == model.get() if that makes sense.
Dillon-Dumesnil
force-pushed
the
ddumesnil/entrance-exam-support-aa-1205
branch
7 times, most recently
from
ede4c38
to
5ac308c
Compare
| if draft_node.module.location not in parent.children: | ||
| if not hasattr(parent, 'children') or draft_node.module.location not in parent.children: |
There was a problem hiding this comment.
So this change happened because I started seeing some flakey test errors when running the test_mongo.py tests (specifically the test_export_course_image and test_export_course_image_nondefault tests). The error would show up as
if draft_node.module.location not in parent.children:
AttributeError: 'HiddenDescriptorWithMixins' object has no attribute 'children'
But I have no idea how or why it would present itself in this way. It feels like maybe something breaks during the import step (see above in this same file during setUpClass), but I still don't understand how it results in this output.
This change felt like a safe protection regardless as it is just ensuring the attribute exists prior to accessing it, but happy to hear thoughts here.
Dillon-Dumesnil
force-pushed
the
ddumesnil/entrance-exam-support-aa-1205
branch
5 times, most recently
from
9218176
to
b107762
Compare
* Adds entrance exam information to the Course Overview object
* Enables hiding other tabs since the get_course_tab_list uses
a Course Overview
* Enables using the entrance exam helper functions to determine
if Entrance exams are being used in this course.
* Posts a message when Entrance Exam is passed to parent container for
usage in the Learning MFE
* Overrides the 'title' field of the courseware tab since the Learning MFE
uses that over the 'name' field.
Dillon-Dumesnil
force-pushed
the
ddumesnil/entrance-exam-support-aa-1205
branch
from
b107762
to
d43ece5
Compare
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
a Course Overview
if Entrance exams are being used in this course.
usage in the Learning MFE
uses that over the 'name' field.
Related to openedx/frontend-app-learning#840