Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old Pymongo pin #30569

Merged
merged 9 commits into from
Jun 27, 2022
Merged

Remove Old Pymongo pin #30569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ca55b45
chore: unpin pymongo
aht007 Jun 10, 2022
ba4a995
fix: ran make upgrade
aht007 Jun 15, 2022
315c1cd
fix: add devstack configurations
aht007 Jun 16, 2022
2e53adf
fix: ran make upgrade
aht007 Jun 16, 2022
b2cc7fc
Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION
aht007 Jun 16, 2022
004ab51
fix: add major version pin
aht007 Jun 20, 2022
357e1cc
Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION
aht007 Jun 22, 2022
9153f97
fix: fix keys issue
aht007 Jun 23, 2022
ee3a082
Merge branch 'master' into aht007/PYMONGO-CONSTRAINT-INVESTIGATION
aht007 Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cms/envs/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,17 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing

OPENAPI_CACHE_TIMEOUT = 0

#####################################################################
# set replica set of contentstore to none as we haven't setup any for cms in devstack
CONTENTSTORE['DOC_STORE_CONFIG']['replicaSet'] = None

#####################################################################
# set replica sets of moduelstore to none as we haven't setup any for cms in devstack
for store in MODULESTORE['default']['OPTIONS']['stores']:
if 'DOC_STORE_CONFIG' in store and 'replicaSet' in store['DOC_STORE_CONFIG']:
store['DOC_STORE_CONFIG']['replicaSet'] = None


#####################################################################
# Lastly, run any migrations, if needed.
MODULESTORE = convert_module_store_setting_if_needed(MODULESTORE)
Expand Down
12 changes: 12 additions & 0 deletions lms/envs/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,22 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing

OPENAPI_CACHE_TIMEOUT = 0

#####################################################################
# set replica set of contentstore to none as we haven't setup any for lms in devstack
CONTENTSTORE['DOC_STORE_CONFIG']['replicaSet'] = None

#####################################################################
# set replica sets of moduelstore to none as we haven't setup any for lms in devstack
for store in MODULESTORE['default']['OPTIONS']['stores']:
if 'DOC_STORE_CONFIG' in store and 'replicaSet' in store['DOC_STORE_CONFIG']:
store['DOC_STORE_CONFIG']['replicaSet'] = None


#####################################################################
# Lastly, run any migrations, if needed.
MODULESTORE = convert_module_store_setting_if_needed(MODULESTORE)


SECRET_KEY = '85920908f28904ed733fe576320db18cabd7b6cd'

EDXNOTES_INTERNAL_API = 'http://edx.devstack.edxnotesapi:18120/api/v1'
Expand Down
5 changes: 3 additions & 2 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ django-oauth-toolkit<=1.3.2
# Will be updated once we update python-dateutil package
matplotlib<3.4.0

# tests failing for pymongo==3.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new pin here to avoid any major release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pymongo<3.11
# constrained in opaque_keys. migration guide here: https://pymongo.readthedocs.io/en/4.0/migrate-to-pymongo4.html
# Major upgrade will be done in separate ticket.
pymongo<4.0.0

# python3-saml==1.10.0 version started breaking a11y tests
python3-saml<1.10.0
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,9 +831,8 @@ pylatexenc==2.10
# via olxcleaner
pylti1p3==1.11.0
# via -r requirements/edx/base.in
pymongo==3.10.1
pymongo==3.12.3
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.in
# -r requirements/edx/paver.txt
# edx-opaque-keys
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,9 +1133,8 @@ pylint-pytest==0.3.0
# via -r requirements/edx/testing.txt
pylti1p3==1.11.0
# via -r requirements/edx/testing.txt
pymongo==3.10.1
pymongo==3.12.3
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/testing.txt
# edx-opaque-keys
# event-tracking
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/paver.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pbr==5.9.0
# via stevedore
psutil==5.9.1
# via -r requirements/edx/paver.in
pymongo==3.10.1
pymongo==3.12.3
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/paver.in
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,9 +1068,8 @@ pylint-pytest==0.3.0
# via -r requirements/edx/testing.in
pylti1p3==1.11.0
# via -r requirements/edx/base.txt
pymongo==3.10.1
pymongo==3.12.3
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
# edx-opaque-keys
# event-tracking
Expand Down