Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve raw content from TinyMCE editor (#31212) #31500

Conversation

asadali145
Copy link
Contributor

Description

This backports #31212 to fix https://discuss.openedx.org/t/text-component-does-not-remove-text-with-link-or-insert-a-link-to-text/9029/5 and https://github.mit.edu/xpro/xpro-issues/issues/338.

During the upgrade to TinyMCE v5, we changed the content format to text. However, it ignores changes in HTML tags. This reverts the format to raw.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 5, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @asadali145! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@asadali145 asadali145 force-pushed the asad/backport-tinymce-fix-for-olive branch from 377aafc to 05f137e Compare January 5, 2023 11:26
@asadali145
Copy link
Contributor Author

Failing tests are not related to this PR. Tests are fixed in master under #31488. I have added a comment for backport to Olive. Checks should pass after that.

@asadali145 asadali145 changed the title fix(olive): retrieve raw content from TinyMCE editor (#31212) [BACKPORT] fix(olive): retrieve raw content from TinyMCE editor (#31212) Jan 5, 2023
During the upgrade to TinyMCE v5, we changed the content format to `text`.
However, it ignores changes in HTML tags. This reverts the format to `raw`.
@asadali145 asadali145 force-pushed the asad/backport-tinymce-fix-for-olive branch from 05f137e to 393776f Compare January 5, 2023 12:44
Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Tested this locally with olive and it works too. The styling, hyperlinks, and text changes all worked for me.

Someone from the open edX team would need to approve and merge this. As for the failing tests i think we can rebase once the fix PR for that is backported as per your comment above. (Oh, this is already done)

@asadali145 asadali145 changed the title [BACKPORT] fix(olive): retrieve raw content from TinyMCE editor (#31212) fix: retrieve raw content from TinyMCE editor (#31212) Jan 5, 2023
@pdpinch pdpinch merged commit 5af42f8 into openedx:open-release/olive.master Jan 5, 2023
@openedx-webhooks
Copy link

@asadali145 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

dimitri-hoareau-WEL pushed a commit to dimitri-hoareau-WEL/edx-platform that referenced this pull request Jan 25, 2023
…x#31500)

During the upgrade to TinyMCE v5, we changed the content format to `text`.
However, it ignores changes in HTML tags. This reverts the format to `raw`.
bprosserc pushed a commit to uarcl/edx-platform that referenced this pull request Feb 10, 2023
…x#31500)

During the upgrade to TinyMCE v5, we changed the content format to `text`.
However, it ignores changes in HTML tags. This reverts the format to `raw`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants