-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retrieve raw content from TinyMCE editor (#31212) #31500
fix: retrieve raw content from TinyMCE editor (#31212) #31500
Conversation
Thanks for the pull request, @asadali145! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
377aafc
to
05f137e
Compare
Failing tests are not related to this PR. Tests are fixed in master under #31488. I have added a comment for backport to Olive. Checks should pass after that. |
During the upgrade to TinyMCE v5, we changed the content format to `text`. However, it ignores changes in HTML tags. This reverts the format to `raw`.
05f137e
to
393776f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 . Tested this locally with olive and it works too. The styling, hyperlinks, and text changes all worked for me.
Someone from the open edX team would need to approve and merge this. As for the failing tests i think we can rebase once the fix PR for that is backported as per your comment above. (Oh, this is already done)
@asadali145 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…x#31500) During the upgrade to TinyMCE v5, we changed the content format to `text`. However, it ignores changes in HTML tags. This reverts the format to `raw`.
…x#31500) During the upgrade to TinyMCE v5, we changed the content format to `text`. However, it ignores changes in HTML tags. This reverts the format to `raw`.
Description
This backports #31212 to fix https://discuss.openedx.org/t/text-component-does-not-remove-text-with-link-or-insert-a-link-to-text/9029/5 and https://github.mit.edu/xpro/xpro-issues/issues/338.
During the upgrade to TinyMCE v5, we changed the content format to
text
. However, it ignores changes in HTML tags. This reverts the format toraw
.