Platform requirements reorg #3224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,8 @@ | |||
| # Python libraries to install directly from github | |||
|
|
|||
| # Third-party: | |||
| git+https://github.com/mitocw/django-cas.git | |||
| git+https://github.com/mfogel/django-settings-context-processor.git | |||
| -e git+https://github.com/edx/django-staticfiles.git@d89aae2a82f2b#egg=django-staticfiles | |||
There was a problem hiding this comment.
This is corrected in https://github.com/edx/edx-platform/pull/3222
There was a problem hiding this comment.
By this you mean, the has for static files, and not the req missing versions entirely, right?
Those were migrated from base.txt.
|
looks good to me. |
| @@ -5,4 +5,4 @@ | |||
| # * One of @e0d, @jarv, or @feanil - to check system requirements | |||
|
|
|||
| # This must be installed after distribute has been updated. | |||
| MySQL-python==1.2.4 | |||
| MySQL-python==1.2.5 | |||
There was a problem hiding this comment.
this change doesn't appear to belong in this PR, does it?
There was a problem hiding this comment.
It's related to wheels, there seems to have been a packaging but in 1.2.4 that probably accounts for our issues with it and distribute, but also prevented it from wheeling up cleanly.
|
other than mysql-python, 👍 |
|
Looks like this PR needs a rebase. |
|
@e0d Can this be merged? |
added 2 commits
July 31, 2014 15:50
rolling back local changes. bad cnp
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is motivated by general code hygiene concerns and moving toward building all ansible managed, and maybe all, environments using pip wheel packages.
This has been tested with the full stack, cf., http://jenkins.edx.org:8080/job/ansible-provision/164/
@jarv @feanil @hkim823 @singingwolfboy @cpennington Please let me know your thoughts, there will be a related configuration PR to follow.