-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: course about page markup and styles improvements #33791
feat: course about page markup and styles improvements #33791
Conversation
Thanks for the pull request, @bydawen! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi! I'm contributing on behalf of Raccoongang |
Hi there @bydawen! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against |
5b9beb5
to
b1085fa
Compare
ac68afe
to
be3526f
Compare
f70063d
into
openedx:open-release/quince.master
* feat: course about page markup and styles improvements * test: update tests according to changes * fix: relocate course organization and return removed prerequisites info * fix: display org info above the course title --------- Co-authored-by: Eugene Dyudyunov <evgen.dyudyunov@raccoongang.com> Co-authored-by: ihor-romaniuk <ihor.romaniuk@raccoongang.com>
Similar PR is opened to the master branch:
#33712
There is some fixes for the course about page:
% if get_course_about_section(request, course, "prerequisites"):
Fixes were also made to the
_course_about.scss
styles, to fix responsive layout of the course about header element.Before fixes:
After fixes: