Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to Quince: copy/paste unit from within a unit in Studio #33866

Conversation

bradenmacdonald
Copy link
Contributor

Description

This is a backport of #33724 to Quince.

Note: using this feature requires the contentstore.enable_copy_paste_units waffle flag. We intend to have this flag enabled by default in Quince.

Supporting information

Ticket: openedx/modular-learning#96

Testing instructions

  1. Enable the contentstore.enable_copy_paste_units waffle flag.
  2. See instructions on the earlier PR.

Deadline

Ideally before Quince release.

…penedx#33724)

(requires the contentstore.enable_copy_paste_units waffle flag)
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 1, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@open-craft-grove
Copy link

Sandbox deployment failed.

Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5664854089.log

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5664854089-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5664854089-requirements.txt

Please check the settings and requirements and retry deployment by updating the pull request or posting a /grove sandbox update comment.

@open-craft-grove
Copy link

Sandbox deployment failed.

Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5665138825.log

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5665138825-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5665138825-requirements.txt

Please check the settings and requirements and retry deployment by updating the pull request or posting a /grove sandbox update comment.

@open-craft-grove
Copy link

Sandbox deployment failed.

Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5707283950.log

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5707283950-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5707283950-requirements.txt

Please check the settings and requirements and retry deployment by updating the pull request or posting a /grove sandbox update comment.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly! Approved!

@arbrandes arbrandes merged commit 847f94b into openedx:open-release/quince.master Dec 8, 2023
43 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the braden/copy-paste-unit-backport branch December 8, 2023 18:09
@open-craft-grove
Copy link

Sandbox destroy request received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants