-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: atlas pull plugins translation | FC-0012 #33922
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
0357fb9
to
397e9a8
Compare
@feanil this is the last edx-platform pull request (hopefully). Please take a look at it before I refactor and add tests. My top question at the moment is whether the plugins i18n tooling should live here or in The current implementation pulls the following plugins correctly:
It doesn't pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach generally looks good to me, are we going to have to extrapolate this to the other IDAs eventually?
common/djangoapps/xblock_django/management/commands/pull_xblock_translations.py
Show resolved
Hide resolved
54af409
to
363e790
Compare
e725aca
to
d4eb538
Compare
d4eb538
to
867eeff
Compare
@feanil This pull request is ready now for review and merge. I've tested it and it worked well. We can refactor it and move utilities into |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Translate
edx_django_utils.plugins
plugins.Add two new commands:
pull_plugin_translations
compile_plugin_translations
TODO
edx_django_utils.plugins
oropenedx-atlas
: feat: Provide i18natlas pull
for Django apps (IDAs) plugins | FC-0012 edx-django-utils#380i18n-tools
: feat: addi18n_tool compile [DIRECTORY]
command | FC-0012 i18n-tools#141Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.