fix: timeout error for legacy page #33965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
bszabo,
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
KristinAoki
deleted the
KristinAoki/remove-usage-location-call-on-legacy-page
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the timeout errors for the legacy Videos page. This change improves performance on the page. When a user has a course with over 100 videos, the legacy and course authoring pages take a long time to load and can eventually lead to a 504 timeout error. In a previous PR the initial fetch for course videos included fetching the usage locations for a video. This data is not used in the legacy Videos page, so this PR updates to only include the data when fetching the data for the course authoring Video page. This change impacts Authors.
Supporting information
JIRA Ticket: TNL-11324
Testing instructions
Deadline
None
Other information
This only fixes the issue for the legacy page. Still looking at pagination for the Course Authoring MFE.