Studio: Authorship Rights Request UI + Dashboard Clean-up #341
Conversation
|
@cahrens can we actually re-send the email verification? |
|
@talbs can we move the "request authorship" block to above the list of courses? What do you think? |
|
@markchang, sure - I'm happy to move that UI element above course listings. You previously mentioned that this feature/request mechanism should be downplayed and not prominently presented to users (which is why I added it below courses). With that in mind, you still cool with moving it? |
|
This is true. I will adjust the copy sometime before we launch. |
|
Thx, @markchang. So, should I go ahead and move those UI elements above courses or are we downplaying them by keeping them where they are? |
|
@cahrens, also, I think I may have broke the "Create/Add a Course" form showing up within the DOM with this static representation. If its something easy to fix in the JS go for it, otherwise I can try to take a look once we have the page's logic in place. |
|
@talbs leave it in place and one of us should update the copy to point in the right direction (above vs. below) |
|
Thanks for the info - I made that quick copy change in all of the states. Hope that helps. |
| <h2 class="title">${_("Welcome, %(name)s!") % dict(name= user.username)}</h2> | ||
|
|
||
| <div class="copy"> | ||
| <p>${_("You don't have any courses you're working on in Studio yet.")}</p> |
There was a problem hiding this comment.
I'm not a huge fan of this wording. Can we get away with something like "You haven't created any courses in Studio yet."?
There was a problem hiding this comment.
Works for me. Someone change plz?
There was a problem hiding this comment.
Presto! Change-O! Copy edited.
|
Okay, revised copy and overwrote some animations - going hands-off until post Hackathon. |
|
@markchang No, we cannot easily resend the e-mail verification. It should be another story. |
|
After talking with @cahrens, I'm going to keep this branch for future efforts, but will be pairing down some of the Dashboard UI changes to be scoped only to authorship rights in a separate branch. |
| <h1>${_("Activation Invalid")}</h1> | ||
| <div class="wrapper-mast wrapper sr"> | ||
| <header class="mast"> | ||
| <h1 class="page-header">${_("Studio Account Activation")}</h1> |
There was a problem hiding this comment.
Product name? Translatable or not?
|
@chrisndodge thanks for the comment about the # of commits. Are there particular standards we should adhere to with commits? I'm guessing a lot of my commits are thickening the history here and am happy to condense. I'd just love: 1) to understand what the standards/guidelines are for commit history now and 2) how to trim down the commits (I think the whole design team could use a walkthrough). Any chance you have answers on those two items? |
|
@cahrens excellent coding job (as usual)! Two things:
Thanks |
|
@talbs I don't know of any guidelines, but I've been asked in the past to use 'rebase -i' to shorten up the commit history. If I'm reading this history correctly, where there a few merges from master as well? Maybe some of the git-heads (@cpennington @gwprice) might be able to better articulate what they believe to be good form. Maybe this just gets let through this time, but they can set some wider Dev standards, if they feel appropriate? |
|
The big red flags to me the several duplicate copies of the same commits, and the merge in from master (I'd rather see it as a rebase on top of master). If there are multiple commits that are really just revisions of the same logical change, then those would ideally be merged together, but I'm less qualified to judge whether the commits are actually in a good state in that regard in their current form. |
|
@chrisndodge No, I don't want to rebase -i. I do not think it is worth the effort, and it is not a required part of our PR process. I think it is more important that the commit messages be helpful/correct (ie, no "checking in work" or "fixing some stuff") than that there be a small number of commits. I've been much more careful about my commit messages. The reason this branch is doing merges instead of rebases is because Brian and I are working on it together. |
|
@chrisndodge In the "big" i18n request that @singingwolfboy shepherded through, we decided to not try to pull edX and Studio out of translatable strings. It seemed too difficult, and instead we were hoping on guidelines for the translators about what is and is not translatable. It's great this discussion is continuing, as I am also concerned about what will happen in translation. However, for now I will stick with the decision we made in that pull request. |
|
@chrisndodge @talbs has addressed Frances' comments, and I addressed those of yours that I plan to do. :) I am seeking a thumbs-up. |
|
+1 LGTM |
Studio: Authorship Rights Request UI + Dashboard Clean-up
SOL-129 Remove Text category filter and add MS contentTypes
…t-social-event Fix getting social login event openedx#341
* xblock/image-coding: Install OLI Image Coding XBlock
eliteu password reset api
[SE-3248] Revert `progress_video` event changes
This working branch adds in some additional UI to a Studio User's Dashboard and include the following changes:
@cahrens, as I mentioned in person, I could use your help to put the proper logic in place to render the proper UI for each use case/scenario. Would you mind as part of your wiring up, trying to abstract this very static mako template? I'm happy to help, but need to know some of the parameters we can use for if statements within the template logic. Feel free to use this branch as your working one as well - I'll be hands-off until any revisions from the group are needed.
@markchang, please take a look through these states and make sure they cover the scenarios we're expecting. Also, I could use your help in producing content for the areas where there is now guided placeholder copy. Mind adding that in via comments here or directly into the branch?
@frrrances, mind taking a spin through my new semantics, markup, and Sass additions to make sure they make sense?
Thanks for your help.