-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: course progress url based on whether the user has learning MFE enabled (for Quince) #34343
fix: course progress url based on whether the user has learning MFE enabled (for Quince) #34343
Conversation
Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
57a337b
to
d3790f4
Compare
Hi @FatemeKhodayari! Just flagging there is a failing test. Would you mind taking a look? |
Hi @mphilbrick211. Actually I'm waiting for @feanil's response to my comment in the master PR as the change causing the failure is because of the suggested solution and I'm not sure what's the best way for fixing the lint import error. If you or any body else knows how this error must be fixed, I'd appreciate the help. |
d3790f4
to
e74ff52
Compare
81e64f7
to
0a8c4ba
Compare
0a8c4ba
to
8fbe55c
Compare
8fbe55c
to
1665f8f
Compare
@FatemeKhodayari thanks for the contribution! Any chance you can make the same fix to the redwood branch as well? |
@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sure. I'll try to get it done by the end of the week. Also thank you for all the help. |
Currently, as we have in Quince, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the
/api/learner_home/init
response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.
Closes #34323