build: add system check to warn of pending devstack settings removal

lms/envs/docs/README.rst

@@ -2,15 +2,10 @@ LMS Configuration Settings
 ==========================
 
 The lms.envs module contains project-wide settings, defined in python modules
-using the standard `Django Settings`_ mechanism.
+using the standard `Django Settings`_ mechanism, plus some Open edX
+particularities, which we describe below.
 
-.. _Django Settings: https://docs.djangoproject.com/en/2.2/topics/settings/
-
-Different python modules are used for different setting configuration options.
-To prevent duplication of settings, modules import values from other modules,
-as shown in the diagram below.
-
-.. image:: images/lms_settings.png
+.. _Django Settings: https://docs.djangoproject.com/en/dev/topics/settings/
 
 
 YAML Configuration Files

openedx/core/djangoapps/util/apps.py

@@ -18,4 +18,5 @@ def ready(self):
         """
         Registers signal handlers at startup.
         """
-        import openedx.core.djangoapps.util.signals  # lint-amnesty, pylint: disable=unused-import, unused-variable
+        import openedx.core.djangoapps.util.signals  # pylint: disable=unused-import, unused-variable
+        import openedx.core.djangoapps.util.checks  # pylint: disable=unused-import, unused-variable

openedx/core/djangoapps/util/checks.py

@@ -0,0 +1,36 @@
+"""
+Miscellaneous system checks
+"""
+from django.conf import settings
+from django.core import checks
+
+
+_DEVSTACK_SETTINGS_MODULES = [
+    "lms.envs.devstack",
+    "lms.envs.devstack_docker",
+    "lms.envs.devstack_optimized",
+    "lms.envs.devstack_with_worker",
+    "cms.envs.devstack",
+    "cms.envs.devstack_docker",
+    "cms.envs.devstack_optimized",
+    "cms.envs.devstack_with_worker",
+]
+
+
+@checks.register(checks.Tags.compatibility)
+def warn_if_devstack_settings(**kwargs):
+    """
+    Raises a warning if we're using any Devstack settings file.
+    """
+    if settings.SETTINGS_MODULE in _DEVSTACK_SETTINGS_MODULES:
+        return [
+            checks.Warning(
+                "Open edX Devstack is deprecated, so the Django settings module you are using "
+                f"({settings.SETTINGS_MODULE}) will be removed from openedx/edx-platform by October 2024. "
+                "Please either migrate off of Devstack, or modify your Devstack fork to work with an externally-"
+                "managed Django settings file. "
+                "For details and discussion, see: https://github.com/openedx/public-engineering/issues/247.",
+                id="openedx.core.djangoapps.util.W247",
+            ),
+        ]
+    return []