tracking in idashboard should only log json-serializable objects #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ike, Seems like the build is failing. It could be due to pep8/pylint violations - we're measuring violation creep and failing builds if they cross a threshold. I'll look into it. |
|
Looks good at a glance. Haven't tried to run it though. |
|
Could you please use unicode() instead of str()? It shouldn't matter for now, but there was some discussion at Stanford about allowing non-ASCII usernames. |
|
changed to unicode |
|
@ormsbee do you want to do another pass - then it seems like we'd be ready to merge. Thanks. |
ormsbee
pushed a commit
that referenced
this pull request
Jul 10, 2013
tracking in idashboard should only log json-serializable objects
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
merging this now because the it looks ok, and it fixes some bugs introduced by the last xserver merge, which are preventing the LMS from running in the current version of master.
antoviaque
referenced
this pull request
in open-craft/edx-platform
Dec 11, 2014
…ster Added back discussion id displaying in studio
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
* fix/pep8: Exclude `test_root` from PEP8 check
idegtiarov
pushed a commit
to Code-Institute-Org/edx-platform
that referenced
this pull request
Sep 17, 2018
…collection Ginkgo rg fix static collection and cherry-pick JS fixes
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the instructor dashboard, in which users are getting an exception when adding staff. The error is caused by
track.views.server_tracktrying to log a non JSON-serializable object, eg instance of User.Error found and logged by Joe Martis.