Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport fix: disable submit button for archived courses (#34920) to quince #35225

Conversation

Anas12091101
Copy link
Contributor

  • fix: disable submit button for archived courses

Description

This PR backports 3b8973a to quince. This disables the submission button for problems in the archived courses.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner"
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
    Before
Screenshot 2024-06-05 at 3 17 16 PM

After
Screenshot 2024-06-05 at 3 14 50 PM

  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

https://github.com/mitodl/hq/issues/4415

Testing instructions

Testing instructions

  • Create a new course in studio.
  • From settings dropdown, select Schedule and Details.
  • Make the course self-paced and add the start date and end date to some past dates.
  • Save the changes and return back to course outline.
  • Create a section, subsection and a problem unit and publish it.
  • In the subsection's settings, set the grading to Homework
  • Go to the unit and click on View Live Version.
  • Validate that the submit button is disabled.

Deadline

None

* fix: disable submit button for archived courses
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Anas12091101!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Anas12091101 Anas12091101 changed the title fix: disable submit button for archived courses (#34920) backport fix: disable submit button for archived courses (#34920) to quince Aug 5, 2024
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @Anas12091101 thanks for back porting it for quince

@ziafazal ziafazal merged commit 3ec40ea into openedx:open-release/quince.master Aug 7, 2024
43 checks passed
@openedx-webhooks
Copy link

@Anas12091101 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ghassanmas pushed a commit to Abstract-Tech/edx-platform that referenced this pull request Oct 30, 2024
…) to quince (openedx#35225)

* fix: disable submit button for archived courses (openedx#34920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants