CMS i18n changes from Tsinghua #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -728,7 +728,7 @@ function saveSetSectionScheduleDate(e) { | |||
| var $thisSection = $('.courseware-section[data-id="' + id + '"]'); | |||
| var html = _.template( | |||
| '<span class="published-status">' + | |||
| '<strong>' + gettext("Will Release: ") + '</strong>' + | |||
| '<strong>' + gettext("Will Release:") + '</strong>' + | |||
There was a problem hiding this comment.
We're going to loose a space here. Seems like we should add a right before the . I'll do it..
|
Also, need to chase down why those two files are being deleted. Doesn't seem related to I18N.... |
|
I think those deleted files are OK to remove +1 from me. I don't know if @singingwolfboy needs to review as well. |
|
Looks good to me. Those files were deleted intentionally -- they aren't used anywhere. |
cpennington
added a commit
that referenced
this pull request
Jul 22, 2013
CMS i18n changes from Tsinghua
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…ering fix another backcompat html bug
e-kolpakov
referenced
this pull request
in open-craft/edx-platform
May 15, 2015
Merge pull request #440 from edx-solutions/ekolpakov/problem-builder-mig...
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 21, 2015
…ange-logger-settings Change logger settings of django.request openedx#427
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
Kluo/revert search
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jan 19, 2021
ju/ednx/JU-6: Hooks support
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@singingwolfboy these changes were left over after you landed the cms i18n changes. Can you review them?