Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to old xml defaults IFF no specified policy for problem nor course. #448

Merged
merged 1 commit into from
Jul 22, 2013

Conversation

dmitchell
Copy link
Contributor

@sarina @cpennington @Lyla-Fischer Can you test/review (as appropriate)?

  • Need to test that xml backed lms behaves as expected when the policy file does and does not override rerandomize & showanswer at the course and problem levels (2 x 2)
  • Need to test that importing an xml course into Studio where the same 2x2 are set/defaulted ends up behaving correctly
  • Need to test that newly created problems in Studio
    • use the course overrides of those values if overridden at course in xml import
    • use the Studio defaults (never/completed) otherwise

@sarina
Copy link
Contributor

sarina commented Jul 19, 2013

Need to test that xml backed lms behaves as expected when the policy file does and does not override rerandomize & showanswer at the course and problem levels (2 x 2)

All 4 cases tested & verified for this.

@sarina
Copy link
Contributor

sarina commented Jul 19, 2013

Note: the "expected" behavior for XML backed LMS (NOT STUDIO!) is that rerandomize=always and showanswer=closed. Just pointing this out as there was some confusion in the chat room.

@sarina
Copy link
Contributor

sarina commented Jul 22, 2013

Nearly everything works except the following:

  • Make XML course with no "rerandomize" or "showanswer" set
  • Import course into studio

    Imported problems CORRECTLY default to XML defaults for "rerandomize" and "showanswer"

  • Now make a new problem

    Newly created problems fall to the Studio defaults for "rerandomize" and "showanswer"

I can send you the .tar.gz I've been testing with, if you want, and you can play around with things more fully. Aside from this one case, everything appears to be working correctly.

@cpennington
Copy link
Contributor

Isn't that the expected behavior? Problems created in Studio have always
defaulted to never/finished. (My question would be whether problems created
in Studio and then exported have the right state upon re-import).

-Cale

On Mon, Jul 22, 2013 at 10:49 AM, Sarina Canelake
notifications@github.comwrote:

Nearly everything works except the following:

  • Make XML course with no "rerandomize" or "showanswer" set
  • Import course into studio > Imported problems CORRECTLY default to
    XML defaults for "rerandomize" and "showanswer"
  • Now make a new problem > Newly created problems fall to the Studio
    defaults for "rerandomize" and "showanswer"

I can send you the .tar.gz I've been testing with, if you want, and you
can play around with things more fully. Aside from this one case,
everything appears to be working correctly.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/448#issuecomment-21349063
.

@sarina
Copy link
Contributor

sarina commented Jul 22, 2013

OK. If that's the case then I'm fine with this PR. It was slightly
unexpected behavior for me but I'm really fine with it.

On Mon, Jul 22, 2013 at 11:04 AM, Calen Pennington <notifications@github.com

wrote:

Isn't that the expected behavior? Problems created in Studio have always
defaulted to never/finished. (My question would be whether problems
created
in Studio and then exported have the right state upon re-import).

-Cale

On Mon, Jul 22, 2013 at 10:49 AM, Sarina Canelake
notifications@github.comwrote:

Nearly everything works except the following:

  • Make XML course with no "rerandomize" or "showanswer" set
  • Import course into studio > Imported problems CORRECTLY default to
    XML defaults for "rerandomize" and "showanswer"
  • Now make a new problem > Newly created problems fall to the Studio
    defaults for "rerandomize" and "showanswer"

I can send you the .tar.gz I've been testing with, if you want, and you
can play around with things more fully. Aside from this one case,
everything appears to be working correctly.


Reply to this email directly or view it on GitHub<
https://github.com/edx/edx-platform/pull/448#issuecomment-21349063>
.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/448#issuecomment-21350164
.

dmitchell added a commit that referenced this pull request Jul 22, 2013
Set to old xml defaults IFF no specified policy for problem nor course.
@dmitchell dmitchell merged commit 0ed0650 into master Jul 22, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…d-to-migrate

add gitreload to lms-migration code
@jzoldak jzoldak deleted the dhm/xml_default branch May 5, 2014 14:55
antoviaque referenced this pull request in open-craft/edx-platform May 28, 2015
Load thread if requested thread isn't loaded yet.
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
…min-rename-cmd

Rename rescind cert command in sysadmin
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request May 30, 2019
fix(course page): Allow unlogged in users to access the course page
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jan 19, 2021
ju/ednx/JU-3: Fix CertificateGenerated.save proxy
jbcurtin pushed a commit to jbcurtin/edx-platform that referenced this pull request Jan 31, 2022
…lilac

[SE-5163] Apply security patches for xss and email search from logout page
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants