Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diff-cover to latest version #460

Merged
merged 2 commits into from
Jul 25, 2013
Merged

Update diff-cover to latest version #460

merged 2 commits into from
Jul 25, 2013

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Jul 22, 2013

@cpennington
Copy link
Contributor

👍 as is, but are you also going to add usage of diff-quality to jenkins/test.sh?

@sarina
Copy link
Contributor Author

sarina commented Jul 22, 2013

@cpennington I added diff-quality to the rake task, which works fine for me locally, but doesn't show up in the build coverage report (http://jenkins.edx.org:8080/job/edx-feature-branch-tests/9563/Diff_Coverage_Report/?) - do you know what I need to do for that?


# Print the quality reports to the console
sh("diff-quality --violations=pep8")
sh("diff-quality --violations=pylint")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is actually where you want to run these. You probably want to add them to the rake quality task, rather than in the coverage section (since they don't depend on the tests).

@sarina
Copy link
Contributor Author

sarina commented Jul 23, 2013

@cpennington thanks. I made this into a rake quality task.

Do you know how I could get the HTML reports to show up in Jenkins? Or should I wait for Will to return to configure that?

@sarina
Copy link
Contributor Author

sarina commented Jul 23, 2013

Moved the task to quality.rake. Put the diff-quality reports into their own reports/ subdirectory, as the reports cover the whole of the platform, not lms/cms/common explicitly.

I tried running this task on a few people's branches, and I had no issue running them. I ran rake pep8; rake pylint; rake quality and everything worked out well with no conflicts.

Still not sure how to make the html reports appear in Jenkins. Thinking about it, I am going to assume this has to be configured explicitly in Jenkins, and I don't have the permissions to configure Jenkins.

@cpennington
Copy link
Contributor

👍

sarina added a commit that referenced this pull request Jul 25, 2013
Update diff-cover to latest version
@sarina sarina merged commit 6923687 into master Jul 25, 2013
@sarina sarina deleted the sarina/update-diffcover branch July 25, 2013 03:18
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Kelketek referenced this pull request in open-craft/edx-platform Jul 15, 2015
Kelketek referenced this pull request in open-craft/edx-platform Jul 15, 2015
Merge pull request #460 from edx-solutions/rc/2015-07-01
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
xavierchan added a commit to xavierchan/edx-platform-1 that referenced this pull request Jun 4, 2019
revert(lms/static/images & sass): revert lms static file to edx open-release/ironwood.master branch
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jan 19, 2021
Adding new translations to edunext-platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants