-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update diff-cover to latest version #460
Conversation
👍 as is, but are you also going to add usage of diff-quality to jenkins/test.sh? |
@cpennington I added |
|
||
# Print the quality reports to the console | ||
sh("diff-quality --violations=pep8") | ||
sh("diff-quality --violations=pylint") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is actually where you want to run these. You probably want to add them to the rake quality
task, rather than in the coverage section (since they don't depend on the tests).
@cpennington thanks. I made this into a Do you know how I could get the HTML reports to show up in Jenkins? Or should I wait for Will to return to configure that? |
Moved the task to I tried running this task on a few people's branches, and I had no issue running them. I ran Still not sure how to make the html reports appear in Jenkins. Thinking about it, I am going to assume this has to be configured explicitly in Jenkins, and I don't have the permissions to configure Jenkins. |
👍 |
Update diff-cover to latest version
Kimth/multiple fileupload
Merge pull request #460 from edx-solutions/rc/2015-07-01
…ount-name Giulio/revert account name
revert(lms/static/images & sass): revert lms static file to edx open-release/ironwood.master branch
Adding new translations to edunext-platform
@cpennington @lapentab