Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration page for Stanford CME #472

Closed
wants to merge 1 commit into from
Closed

Conversation

dcadams
Copy link
Contributor

@dcadams dcadams commented Jul 22, 2013

New app cme_registration
New table cme_registration

********* Migration required for this PR

@ghost ghost assigned jbau and kluo Jul 22, 2013
@jrbl
Copy link
Contributor

jrbl commented Aug 6, 2013

QA checklist run:

  • needs rebase
  • /^register/ URL: do we want to leave the non-CME registration enabled when the CME registration is enabled?
  • Design point: do we want to make the registration apparatus pluggable and make the exclusivity default/other rather than default/cme?
  • what happens when the MITX_FEATURES['DISABLE_CME_REGISTRATION_TESTS'] variable is completely undefined? (principal: optional features should have optional configuration)
  • CHANGELOG needs update
  • Since this is smashed into one big commit, can we blow away the migrations and recrceate them to get one big migration, also? Also were the migrations created as described in https://edx-wiki.atlassian.net/wiki/display/ENG/Creating+and+Migrating+Database+Table?src=search ?
  • I'd prefer a more loquacious log message. Complete sentences, description of what it does. Don't shy from embedding URLs if the resources they point to are public. 2nd line should remain blank. I like that you called out the required migration, and think I'll add that to the QA checklist.
  • I had one unit test failure on my local test run
  • Test coverage seems to be less than 95%. I can't tell if that's because of the migration though.
  • There are a few pep8 and pylint violations.

I can talk any of this over in meatspace if you'd like.

New app cme_registration
New table cme_registration

********* Migration required for this branch

Provides a new registration page specifically for Stanford/CME
which will be used to capture specific information from their
registered students.
The setting 'USE_CME_REGISTRATION' determines the use of this
registration page.
JSON call to create new edX account; modified for the CME registration form.
Used by form in signup_modal.html, which is included into navigation.html
'''
jason_string = {'success': False}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a difference between jason_string and json_string? As much as I'd like my name in the code, I think json_string is probably more correct.

@singingwolfboy
Copy link
Contributor

What's the status of this PR? Can it be merged? If not, can we close it?

@chrisndodge
Copy link
Contributor

@jbau yea, what's the status on the PR here? Do you need this merged in?

@jbau
Copy link

jbau commented Sep 5, 2013

Sorry this has been on my plate to look at / code review for awhile. Will take care of this this week.

On Sep 4, 2013, at 12:44 PM, chrisndodge notifications@github.com wrote:

@jbau yea, what's the status on the PR here? Do you need this merged in?


Reply to this email directly or view it on GitHub.

@jbau
Copy link

jbau commented Sep 11, 2013

closing (i don't think it makes sense for this to go into master), will likely merge into edx-west/release, but squashed.

@jbau jbau closed this Sep 11, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…ogress

Feature/victor/per course progress
hachiyanagi-ks added a commit to nttks/edx-platform that referenced this pull request Nov 16, 2015
…s-header-logo

Enable to configure the header logo openedx#470
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
…e-sha-sac

Update SHA for xblock-submit-and-compare
xavierchan added a commit to xavierchan/edx-platform-1 that referenced this pull request Aug 19, 2019
fix(translation): fix translations bug
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
…nboarding is past due (openedx#472)

[MST-746](https://openedx.atlassian.net/browse/MST-746)

The ProctoringInfoPanel displays information in a learner's course outline about the state of the learner's onboarding. It displays a link to navigate the learner to the onboarding exam if it is available. If the onboarding exam is not yet released, it displays information about the release date. This code changes adds an "Onboarding Past Due" message to the link if the onboarding is past due, as determined by a call to the LMS onboarding endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants