Add an XBlock student_view to XModule #477
Conversation
|
|
||
| class Module(XModule): | ||
| def get_html(self): | ||
| return '<input type="hidden" class="schematic" name="{item_id}" height="480" width="640">'.format(item_id=self.item_id) |
There was a problem hiding this comment.
Why are we getting rid of this module? Its it just not getting used?
There was a problem hiding this comment.
It's not in setup.py, so no one could have used it, and it's broken as is.
There was a problem hiding this comment.
Is there anything else that we can get rid of, using the same criterion?
There was a problem hiding this comment.
I don't believe so.
|
Just one typo, and otherwise looks good. |
|
|
||
| # Test that for all of the leaf XModule Descriptors, | ||
| # the student_view wrapper returns the same thing in its content | ||
| # as get_html returns |
There was a problem hiding this comment.
Why aren't these docstrings?
There was a problem hiding this comment.
Because I didn't want them to muddle the test names
|
I think that's my only comment. Otherwise, it looks good. |
|
|
||
| Makes no use of the context parameter | ||
| """ | ||
| return Fragment(unicode(self.get_html())) |
There was a problem hiding this comment.
What's coming out of self.get_html() exactly? Because if it's a unicode object, this call to unicode() seems redundant. And if it's a UTF-8 byte string, it seems like you'd have to pass in the encoding so it doesn't default to ASCII?
There was a problem hiding this comment.
Hrm. Good point. It's coming out as unicode in the lms, because we're telling mako to render it that way. So I'll remove that call.
This just wraps XModule.get_html, and ignores javascript and css for now. [LMS-189]
|
👍 |
Add an XBlock student_view to XModule
…ission_names Allowing filesubmissions to specify which files are allowed and require that certain files are present.
…-accounts-tab Added checking information before show tabs
fix(underscore): move underscore to theme did not work
This just wraps XModule.get_html, and ignores javascript and css for
now.
[LMS-189]
@dianakhuang @brianhw @ormsbee: Review?