instructor dash fixes #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. 🤘 |
|
👍 Contact Jay to get it in this week's release |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Added outofocus for sign in and log in forms
itsjeyd
referenced
this pull request
in open-craft/edx-platform
Mar 4, 2016
Hash update: Problem Builder
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 30, 2016
dfrojas
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Aug 31, 2017
…-viewer-xblock Revert "Add 3d Viewer xBlock"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the legacy instructor dash code has lines in it like "elif 'List course staff' in action", running ugettext on the input buttons' values in the dashboard template can cause buttons to break, such as the enroll students button. Since we're going to be renovating the instructor dash, we should revert i18n on the legacy template to ensure against such breakages.
@mlsteele
@sarina