remove 'preview' from urls in enrollment emails sent while previewing a ... #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's going to be replacing this? Something in Miles' changes? |
|
It makes sense that if we're just going to make another story that this is fine for now. |
|
My changes don't include any email sending stuff. |
|
@ormsbee ? |
|
This makes me sad. |
|
But please merge. |
adampalay
added a commit
that referenced
this pull request
Aug 13, 2013
remove 'preview' from urls in enrollment emails sent while previewing a ...
itsjeyd
referenced
this pull request
in open-craft/edx-platform
Mar 24, 2016
Improve performance of Organization list and retrieve APIs
dfrojas
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Aug 31, 2017
…t-version-014 Update xblock free text to version 0.1.4
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...course
A temporary fix to make sure, if an instructor sends out enrollment or unenrollment emails when previewing a course, that students do not receive emails to register at preview.<site_name>, but just at <site_name>. So instead of preview.edge.edx.org, a student would be directed to edge.edx.org. It's hacky, but temporary.
Addresses https://edx-wiki.atlassian.net/browse/LMS-726
@ormsbee
@dianakhuang