Updated acceptance tests to match new behavior in video captions. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved the reset cookies call and ran it ~10 times with no failures. @jzoldak , take another look? |
|
@wedaly the last sceanrio in cms/djangoapps/contentstore/features/video-editor.feature still fails for me. :( |
|
👍 |
wedaly
pushed a commit
that referenced
this pull request
Sep 2, 2013
Updated acceptance tests to match new behavior in video captions.
ny0m
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Aug 14, 2017
…/version_update MCKIN-5256: Diagnostic feedback version update
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jul 18, 2018
…eement-switch ENH: setting to remove platform name from registration page in honor
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Abdul-Muqadim-Arbisoft
pushed a commit
to edly-io/edx-platform
that referenced
this pull request
May 8, 2024
Installing from source triggers a warning on pip 23.0.1 if pyproject.toml is not present. Building does not require any special dependencies, so we just add a simple pyproject.toml file. Close openedx#836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the tests to reflect recent changes to how the video player handles captions:
The default video doesn't have captions, so the CC button gets hidden. The test cases now upload subtitles explicitly so the CC button shows up when we need it. This has the nice side-effect of testing the current subtitle-upload workflow.
Reviewers: @jzoldak @valera-rozuvan