Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading packing #456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrading packing #456

wants to merge 2 commits into from

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Dec 4, 2023

#454

Packing version has made some breaking changes and it no more verifying the string versions.
pypa/packaging#407

@@ -3,5 +3,5 @@
40,edx-opaque-keys,yes,-,2.2.0,2.2.0,-,"Feb 1, 2021",,,
103,django-storages,,1.11,1.8,1.1,-,"Jun 21, 2021",https://github.com/edx/upgrades/issues/44,,
110,edx-django-utils,yes,-,master,4.2.0,4.2.0,"Jul 14, 2021",BOM-2634,,
30,djangorestframework,,3.12.3,3.11.0,3.12.0,p,"Jun 30, 2021",,,3.12.4
30,djangorestframework,,3.12.3,3.11.0,3.12.0,3.13.0,"Jun 30, 2021",,,3.12.4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p was typo.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da64bcd) 81.72% compared to head (cd4aee8) 81.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files          24       24           
  Lines        1302     1302           
=======================================
  Hits         1064     1064           
  Misses        238      238           
Flag Coverage Δ
unittests 81.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais786 awais786 marked this pull request as ready for review December 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants