-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migrations check #196
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 18 18
Lines 1996 1996
Branches 125 125
=======================================
Hits 1865 1865
Misses 118 118
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I think that the check should be failing on this PR I made off of your branch: https://github.com/openedx/edx-submissions/pull/197/files |
Wow, it looks like those aren't actually doing that check, it's just a unit test that's running? check migrations and check migrations mysql8 both pass! it's a unit test that fails, specifically this one. |
@jansenk, is that to say we should be doing that as a unit test, as in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test fails on my test branch! looks great
https://github.com/openedx/edx-submissions/actions/runs/5083648614/jobs/9134917710?pr=197
About
Adds a migrations check, mirrored after similar workflows in edx-platform, edx-notes-api, and edx-analytics-dashboard, to name a few.
Migration check further modified (based on this test) to actually fail when there are missing migration files.
JIRA: https://2u-internal.atlassian.net/browse/AU-820
Testing Instructions
Migrations check on mysql8
) appears on PRs. Should fail if a migration fails or is missing for future PRs.