Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash migrations for edxval. #214

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Squash migrations for edxval. #214

merged 2 commits into from
Apr 13, 2020

Conversation

dianakhuang
Copy link
Contributor

@dianakhuang dianakhuang commented Apr 10, 2020 •
edited
Loading

robrap
robrap reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we'll discuss, having an initial commit with the auto-generated file will make PR review much simpler.

edxval/migrations/0001_squashed_0016_add_transcript_credentials_model.py
},
bases=(models.Model, edxval.models.ModelFactoryWithValidation),
),
migrations.AddField(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to roll the AddFields into the CreateModels?

edxval/settings.py
@@ -187,3 +187,17 @@
CIELO24_BASE_API_URL="https://sandbox.cielo24.com/api",
CIELO24_LOGIN_URL="https://sandbox.cielo24.com/api/account/login"
)

# Required by Django 2.2 to run management commands.
TEMPLATES = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I'd get changes like this into a separate PR ahead of the squash migrations, so the squash migrations will contain nothing but the squash.

@dianakhuang dianakhuang merged commit f0d7381 into master Apr 13, 2020
@dianakhuang dianakhuang deleted the diana/squash-migrations branch April 13, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianakhuang @robrap