Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated 'upgrade requirements' workflow to use reusable workflows #335

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

edx-requirements-bot
Copy link
Contributor

Additional information from script execution

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran
cd .github/workflows;  TEAM_REVIEWERS=$(grep 'team-reviewers=' upgrade-python-requirements.yml -m 1 | awk '{print $2}'); TEAM_REVIEWERS=${TEAM_REVIEWERS/--team-reviewers=/}; SCHEDULE=$(grep 'cron:' upgrade-python-requirements.yml -m 1 | sed 's/^.*: //');   EMAIL_TO=$(grep 'to:' upgrade-python-requirements.yml -m 1 | sed 's/^.*: //'); [ -z $(grep 'Send success notification' upgrade-python-requirements.yml) ] && SEND_SUCCESS_NOTIFICATION=$(echo false) || SEND_SUCCESS_NOTIFICATION=$(echo true); : > upgrade-python-requirements.yml; printf "name: Upgrade Requirements\n\non:\n  schedule:\n     - cron: ${SCHEDULE}\n  workflow_dispatch:\n     inputs:\n       branch:\n         description: 'Target branch to create requirements PR against'\n         required: true\n         default: \$default-branch\njobs:\n   call-upgrade-python-requirements-workflow:\n    with:\n       branch: \${{ github.event.inputs.branch }}\n       team_reviewers: ${TEAM_REVIEWERS}\n       email_address: ${EMAIL_TO}\n       send_success_notification: ${SEND_SUCCESS_NOTIFICATION}\n    secrets:\n       requirements_bot_github_token: \${{ secrets.REQUIREMENTS_BOT_GITHUB_TOKEN }}\n       requirements_bot_github_email: \${{ secrets.REQUIREMENTS_BOT_GITHUB_EMAIL }}\n       edx_smtp_username: \${{ secrets.EDX_SMTP_USERNAME }}\n       edx_smtp_password: \${{ secrets.EDX_SMTP_PASSWORD }}\n    uses: edx/.github/.github/workflows/upgrade-python-requirements.yml@master\n" >> upgrade-python-requirements.yml;

The following packages were installed:
``

@Jawayria Jawayria requested a review from a team November 29, 2021 12:56
Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one concern from my side.

body: Upgrade python requirements workflow in ${{github.repository}} failed! For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
call-upgrade-python-requirements-workflow:
with:
branch: ${{ github.event.inputs.branch }}
Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why're we not using ${{ github.event.inputs.branch || '$default-branch' }} here instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If branch isn't given as input, the default value for branch input will be used which is itself '$default-branch' so both would work fine.

@Jawayria Jawayria merged commit f7160d5 into master Nov 30, 2021
@Jawayria Jawayria deleted the jenkins/reusable-workflow-6ad1e19 branch November 30, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants