fix: SubsidyAPIHTTPError should not drop the HTTP response error #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
approved these changes
Jan 30, 2024
pwnage101
force-pushed
the
pwnage101/fix-subsidy-api-error-logging
branch
from
cbc248c
to
86b23e2
Compare
Before this change, the SubsidyAPIHTTPError source code assumed that we can test the truthiness of requests.models.Response as a proxy for existence. This is a fatal assumption because the Response objects overrides __bool__() in a way that all error codes are falsey. This resulted in completely dropping the error information from the response object. After this change, error codes will actually be propagated up into error logging tools (New Relic, Splunk, etc.). requests.models.Response implementation: https://docs.python-requests.org/en/latest/_modules/requests/models/#Response
pwnage101
force-pushed
the
pwnage101/fix-subsidy-api-error-logging
branch
from
86b23e2
to
16790eb
Compare
macdiesel
approved these changes
Jan 31, 2024
iloveagent57
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the SubsidyAPIHTTPError source code assumed that we can test the truthiness of requests.models.Response as a proxy for existence. This is a fatal assumption because the Response objects overrides bool() in a way that all error codes are falsey. This resulted in completely dropping the error information from the response object.
After this change, error codes will actually be propagated up into error logging tools (New Relic, Splunk, etc.).
requests.models.Response implementation: https://docs.python-requests.org/en/latest/_modules/requests/models/#Response