Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating group members with aggregate pagination num pages #465

Merged

Conversation

alex-sheehan-edx
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx commented May 8, 2024

Description:
mishap with num pages pagination response value when sorting by enrollment count

Screenshot 2024-05-08 at 3 01 35 PM

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@alex-sheehan-edx alex-sheehan-edx requested review from iloveagent57, a team and bcitro May 8, 2024 18:57
@alex-sheehan-edx alex-sheehan-edx merged commit 581356b into main May 9, 2024
4 checks passed
@alex-sheehan-edx alex-sheehan-edx deleted the asheehan-edx/sort-by-enrollment-num-pages-fix branch May 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants