Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: adding Datadog monitoring middleware #548

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

pmakwana93
Copy link
Contributor

@pmakwana93 pmakwana93 commented Aug 29, 2024

Description:
Adding Datadog monitoring middleware as per https://docs.google.com/spreadsheets/d/1sh9eE-vT5JysI4BAx_qlkhzZ0hEujM_B18qL4XQoq1k/edit?gid=56476385#gid=56476385

Slack reference: https://twou.slack.com/archives/C0495EETUVC/p1724856564259579

JIRA: ENT-9422

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

Comment on lines 86 to 88
# Enables monitoring utility for writing custom metrics.
'edx_django_utils.monitoring.DeploymentMonitoringMiddleware',
'edx_django_utils.monitoring.middleware.MonitoringCustomMetricsMiddleware',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Keeping comment next to relevant import

Suggested change
# Enables monitoring utility for writing custom metrics.
'edx_django_utils.monitoring.DeploymentMonitoringMiddleware',
'edx_django_utils.monitoring.middleware.MonitoringCustomMetricsMiddleware',
'edx_django_utils.monitoring.DeploymentMonitoringMiddleware',
# Enables monitoring utility for writing custom metrics.
'edx_django_utils.monitoring.middleware.MonitoringCustomMetricsMiddleware',

@pmakwana93 pmakwana93 merged commit 5a4bb19 into main Sep 4, 2024
3 checks passed
@pmakwana93 pmakwana93 deleted the upgrade_dd_middleware branch September 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants