Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update start_date logic to consider self paced and old start_dates #560

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: update start_date logic to consider self paced and old start_dates #560

merged 1 commit into from
Sep 23, 2024

Conversation

brobro10000
Copy link
Member

Description:
Checks if the start_date is before the START_DATE_DEFAULT_TO_TODAY_THRESHOLD_DAYS value (currently 14) and sends that value to braze to be parsed for tasks related to learner credit assignment. The main intentions behind this addition is to handle OCM course start dates which start very far in the past.

Jira:
ENT-XXXX

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@brobro10000 brobro10000 changed the title feat: default stayle start_dates to today in braze assignment task feat: default stale start_dates to today in braze assignment task Sep 10, 2024
@brobro10000 brobro10000 force-pushed the hu/ent-9452-2 branch 2 times, most recently from 527eac4 to a549dca Compare September 11, 2024 15:37
@brobro10000 brobro10000 marked this pull request as ready for review September 11, 2024 15:39
@brobro10000 brobro10000 force-pushed the hu/ent-9452-2 branch 3 times, most recently from ebb2666 to 93e1e5e Compare September 19, 2024 16:51
@brobro10000 brobro10000 changed the title feat: default stale start_dates to today in braze assignment task feat: update start_date logic to consider self paced and old start_dates Sep 19, 2024
macdiesel
macdiesel approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@macdiesel macdiesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR Hamzah.

enterprise_access/apps/content_assignments/utils.py Outdated Show resolved Hide resolved
@brobro10000 brobro10000 merged commit 3613a5e into main Sep 23, 2024
3 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9452-2 branch September 23, 2024 16:36
@brobro10000 brobro10000 mentioned this pull request Sep 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdiesel macdiesel macdiesel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brobro10000 @macdiesel