Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forced assignment redemption assigns course run key #570

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

iloveagent57
Copy link
Contributor

Description:
Currently, the forced redemption model persists a course run key to force redeem. It also creates an assignment if in an assignment-based policy. However, it creates the assignment with a course key, and not the run key.

Instead of doing this, we should simply fetch the metadata for the course run key that’s persisted in the forced redemption instance. As long as we get something back, we should just use this persisted value when creating the related assignment record.

Jira:
https://2u-internal.atlassian.net/browse/ENT-9562

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@iloveagent57 iloveagent57 merged commit cad68f6 into main Oct 3, 2024
3 checks passed
@iloveagent57 iloveagent57 deleted the aed/forced-run-redemption branch October 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants