feat!: add conditional TypeScript support to the ESLint config. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Apr 14, 2023
| "eslint": "^6.8.0 || ^7.0.0 || ^8.0.0", | ||
| "@typescript-eslint/eslint-plugin": "^5.58.0", | ||
| "@typescript-eslint/parser": "^5.58.0", | ||
| "eslint": "^7.32.0 || ^8.2.0", |
There was a problem hiding this comment.
BREAKING CHANGE: eslint@^6.8.0 was removed from peer dependencies as its no longer supported with the introduction of eslint-config-airbnb-typescript.
adamstankiewicz
commented
Apr 14, 2023
| "eslint-config-airbnb": "^18.0.1 || ^19.0.0", | ||
| "eslint-plugin-import": "^2.20.0", | ||
| "eslint-config-airbnb-typescript": "^17.0.0", | ||
| "eslint-plugin-import": "^2.25.3", |
There was a problem hiding this comment.
BREAKING CHANGE: This peer dependency's version was bumped slightly as eslint-config-airbnb-typescript specifies ^2.25.3 as the minimum.
adamstankiewicz
force-pushed
the
ags/airbnb-typescript
branch
2 times, most recently
from
58f040f to
43941c2
Compare
BREAKING CHANGE: Drops support for `eslint` ^6.8.0; `@edx/eslint-config` must now be used with at least `eslint` versions ^7.32.0 or ^8.2.0.
adamstankiewicz
force-pushed
the
ags/airbnb-typescript
branch
from
43941c2 to
093436f
Compare
marlonkeating
approved these changes
Apr 14, 2023
|
We will merge this PR into |
|
🎉 This PR is included in version 4.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BilalQamar95
added a commit
that referenced
this pull request
Apr 5, 2024
* feat!: add conditional TypeScript support to the ESLint config. (#124) BREAKING CHANGE: Drops support for `eslint` ^6.8.0; `@edx/eslint-config` must now be used with at least `eslint` versions ^7.32.0 or ^8.2.0. * refactor: updated package-lock * refactor: updated typescript-eslint parser & plugin * refactor: updated package-lock --------- Co-authored-by: Adam Stankiewicz <agstanki@gmail.com> Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
eslint@^6.8.0;@edx/eslint-configmust now be used with at leasteslint@^7.32.0oreslint@^8.2.0.eslint-plugin-import@^2.25.3.Adds conditional support for TypeScript in the shared ESLint configuration. Relies on trying to find
tsconfig.jsonfile in the root folder of consumers' project.If found, conditionally extends
airbnb-typescriptand sets theparserOptions.projectto the discoveredtsconfig.jsonfile. If atsconfig.jsonfile is not found, does not add support for TypeScript to avoid throwing an error about a missingtsconfig.jsonfile inparserOptions.projectwhen usingairbnb-typescriptwithout atsconfig.jsonfile.