Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use new method for setting client id #225

Merged
merged 6 commits into from
Jan 25, 2024
Merged

fix: use new method for setting client id #225

merged 6 commits into from
Jan 25, 2024

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented Jan 24, 2024 •
edited
Loading

Use the new method in openedx-events instead of accessing the settings directly

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • Noted any: Concerns, dependencies, deadlines, tickets, testing instructions

@rgraber rgraber changed the title fix: use a better name for the client.id setting fix: use new method for setting client id Jan 25, 2024
@rgraber rgraber merged commit e8df078 into main Jan 25, 2024
9 checks passed
@rgraber rgraber deleted the rsgraber/20240124-fix-docstring branch January 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgraber @timmc-edx