refactor: migrate off modal paragon depreciation components #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them into latest paragon modals
|
Thanks for the pull request, @Mashal-m! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
Mashal-m
changed the title
Codecov ReportBase: 38.75% // Head: 38.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 38.75% 38.78% +0.03%
==========================================
Files 110 110
Lines 2281 2279 -2
Branches 622 620 -2
==========================================
Hits 884 884
+ Misses 1312 1310 -2
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abdullahwaheed
approved these changes
Nov 4, 2022
26 tasks
|
@Mashal-m, sprint check: do you mind resolving conflicts and squashing your commits? |
PKulkoRaccoonGang
pushed a commit
to PKulkoRaccoonGang/frontend-app-account
that referenced
this pull request
Dec 11, 2022
) * refactor: worked on modal paragon depreciation component and changed them into latest paragon modals * refactor: migrate off modal paragon depreciation components * fix: fix eslint and commit message * fix: units tests were not working, its fixed * test: add unit tests in modal * test: add unit tests in id verfication modal * refactor: convert test cases from enzyme to react testing library * refactor: remove empty file
moonesque
pushed a commit
to edSPIRIT/frontend-app-account
that referenced
this pull request
Nov 11, 2023
) * refactor: worked on modal paragon depreciation component and changed them into latest paragon modals * refactor: migrate off modal paragon depreciation components * fix: fix eslint and commit message * fix: units tests were not working, its fixed * test: add unit tests in modal * test: add unit tests in id verfication modal * refactor: convert test cases from enzyme to react testing library * refactor: remove empty file
dcoa
pushed a commit
to eduNEXT/frontend-app-account
that referenced
this pull request
Dec 4, 2023
) * refactor: worked on modal paragon depreciation component and changed them into latest paragon modals * refactor: migrate off modal paragon depreciation components * fix: fix eslint and commit message * fix: units tests were not working, its fixed * test: add unit tests in modal * test: add unit tests in id verfication modal * refactor: convert test cases from enzyme to react testing library * refactor: remove empty file
dcoa
added a commit
to eduNEXT/frontend-app-account
that referenced
this pull request
Dec 15, 2023
* chore: update dependencies to alpha version * fix: migrated functions to arrow functions to fix linting * Paragon form component deprecations (openedx#612) * refactor: removed deprecated paragon components from CoachingToggle and used alternatives * refactor: removed deprecated paragon components from ConfirmationModal and used alternatives * refactor: removed deprecations from EditableField and created separate component for SelectField * refactor: updated DemographicsSection to use new select component * refactor: removed deprecations from EmailField and used alternatives * refactor: removed deprecated Input from CoachingConsentForm * refactor: removed deprecated Input from DemographicsSection * refactor: removed deprecated Input from SummaryPanel component * refactor: removed deprecated CheckBox and used Form.CheckBox * refactor: fixed unit tests * refactor: changes based on PR reviews * fix: linting issue * refactor: migrate off modal paragon depreciation components (openedx#654) * refactor: worked on modal paragon depreciation component and changed them into latest paragon modals * refactor: migrate off modal paragon depreciation components * fix: fix eslint and commit message * fix: units tests were not working, its fixed * test: add unit tests in modal * test: add unit tests in id verfication modal * refactor: convert test cases from enzyme to react testing library * refactor: remove empty file * fix: downgrade paragon to 21.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Migrate off deprecated Paragon components
Migrated off Modal deprecated components into latest modals
Confirmation Modal Before
Confirmation Modal After
Success Modal Before
Success Modal After
ID verification Before
ID verification After