fix: Migrate welcome page and recommendations tests to RTL #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 124 124
Lines 2282 2282
Branches 637 637
=======================================
Hits 1988 1988
Misses 285 285
Partials 9 9 ☔ View full report in Codecov by Sentry. |
attiyaIshaque
force-pushed
the
attiya/VAN-1772-RTL-tests
branch
from
c3690fd
to
7e3729a
Compare
|
|
||
| expect(progressiveProfilingPage.find('a.pgn__hyperlink').text()).toEqual('Learn more about how we use this information.'); | ||
| const infoMessage = 'Learn more about how we use this information.'; | ||
| const findByTextWithClass = (container, text, className) => Array.from(container.querySelectorAll(`.${className}`)).find( |
There was a problem hiding this comment.
why can't we directly find by text?
There was a problem hiding this comment.
Yeah, we can use it like this. Sure i will change it.
const { getByText } = render(reduxWrapper(<IntlProgressiveProfilingPage />));
const learnMoreButton = getByText('Learn more about how we use this information.');
expect(learnMoreButton).toBeDefined();
There was a problem hiding this comment.
@syedsajjadkazmii I have changed it.
attiyaIshaque
force-pushed
the
attiya/VAN-1772-RTL-tests
branch
from
7e3729a
to
37ec14b
Compare
syedsajjadkazmii
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This task involves migrating our existing tests for the 'Welcome Page' and 'Recommendations' functionalities from Enzyme to React Testing Library (RTL).
JIRA
VAN-1772