fix: Migrate Registration tests to RTL #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 124 124
Lines 2282 2282
Branches 637 637
=======================================
Hits 1988 1988
Misses 285 285
Partials 9 9 ☔ View full report in Codecov by Sentry. |
attiyaIshaque
force-pushed
the
attiya/VAN-1769-RTL-tests
branch
3 times, most recently
from
a68fc41
to
1fdaad0
Compare
attiyaIshaque
force-pushed
the
attiya/VAN-1769-RTL-tests
branch
from
1fdaad0
to
5d33116
Compare
| target: { value: '', name: 'country' }, | ||
| relatedTarget: { type: 'button', className: 'btn-icon pgn__form-autosuggest__icon-button' }, |
There was a problem hiding this comment.
yes its working fine.
| const { container } = render(routerWrapper(reduxWrapper(<IntlCountryField {...props} />))); | ||
| const countryInput = container.querySelector('input[name="country"]'); | ||
|
|
||
| fireEvent.focus(countryInput); |
There was a problem hiding this comment.
In one of test case focus was not working because it behaves async so we need to put in 'act' just want to confirm that is it working fine?
There was a problem hiding this comment.
Yup. working perfectly without getting a console error.
| const { container } = render(routerWrapper(reduxWrapper(<IntlEmailField {...props} />))); | ||
|
|
||
| const emailInput = container.querySelector('input#email'); | ||
| fireEvent.focus(emailInput, { target: { value: '', name: 'email' } }); |
ahtesham-quraish
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate existing tests for the 'Registration' functionality from Enzyme to React Testing Library (RTL).
JIRA
VAN-1769
How Has This Been Tested?
Locally