refactor: depreciate enzyme #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
- Coverage 87.12% 87.04% -0.09%
==========================================
Files 124 124
Lines 2284 2284
Branches 638 638
==========================================
- Hits 1990 1988 -2
- Misses 285 287 +2
Partials 9 9 ☔ View full report in Codecov by Sentry. |
zainab-amir
approved these changes
Jan 16, 2024
| expect(field.type()).toEqual('select'); | ||
| expect(fieldRenderer.find('label').text()).toEqual('Year of Birth'); | ||
| expect(value).toEqual(1997); | ||
| expect(input.type).toEqual('select-one'); |
There was a problem hiding this comment.
why has it changed to select-one instead of select?
There was a problem hiding this comment.
It should be select, but the element was giving the type select-one, although I tried to debug the element and found the input type was select
| expect(value).toEqual(1997); | ||
| expect(input.type).toEqual('select-one'); | ||
| expect(label.textContent).toContain(fieldData.label); | ||
| expect(value).toEqual('1997'); |
There was a problem hiding this comment.
Also, why does RTL expect the value to be a string?
There was a problem hiding this comment.
In our component, the value was set in integer, but in the unit test in changeHandler function, the value was getting in string.
move unit test from enzyme to RTL VAN-1792
mubbsharanwar
force-pushed
the
VAN-1792
branch
from
6c1d94f
to
69c7742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move unit tests from enzyme to RTL.
VAN-1792